Skip to content

NodeDependencies: prevent unnecessary FileHelper::normalizePath() calls#4809

Merged
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
staabm:no-norm
Jan 24, 2026
Merged

NodeDependencies: prevent unnecessary FileHelper::normalizePath() calls#4809
ondrejmirtes merged 1 commit intophpstan:2.1.xfrom
staabm:no-norm

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Jan 23, 2026

in shopware this is invoked a lot, and I can see on my machine that the path oftentimes already matches even before normalization

grafik

its in the top 5 used calls when running php vendor/bin/phpstan analyze tests/integration/Core/System --debug

grafik

@ondrejmirtes
Copy link
Member

Nice, thank you!

@ondrejmirtes ondrejmirtes merged commit 5574395 into phpstan:2.1.x Jan 24, 2026
630 of 639 checks passed
@staabm staabm deleted the no-norm branch January 24, 2026 08:04
ruudk pushed a commit to ruudk/phpstan-src that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants